Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: verification script must return exactly one value #1332

Merged
merged 1 commit into from
Aug 18, 2020

Conversation

roman-khimov
Copy link
Member

C# node is quite picky as it expects there to be exactly one value returned,
but our testchain actually adds 4 signatures for multisig cases instead of 3
which makes it technically incompatible with C# node.

C# node is quite picky as it expects there to be exactly one value returned,
but our testchain actually adds 4 signatures for multisig cases instead of 3
which makes it technically incompatible with C# node.
@roman-khimov roman-khimov added the bug Something isn't working label Aug 17, 2020
@roman-khimov roman-khimov added this to the v0.91.0 milestone Aug 17, 2020
@codecov
Copy link

codecov bot commented Aug 17, 2020

Codecov Report

Merging #1332 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1332      +/-   ##
==========================================
+ Coverage   68.30%   68.34%   +0.04%     
==========================================
  Files         216      216              
  Lines       18584    18586       +2     
==========================================
+ Hits        12694    12703       +9     
+ Misses       5201     5197       -4     
+ Partials      689      686       -3     
Impacted Files Coverage Δ
pkg/core/blockchain.go 71.39% <100.00%> (+0.06%) ⬆️
pkg/internal/testchain/address.go 83.33% <100.00%> (ø)
pkg/smartcontract/parameter.go 83.55% <0.00%> (+1.00%) ⬆️
pkg/rpc/client/wsclient.go 84.56% <0.00%> (+1.34%) ⬆️
pkg/core/native/blocked_accounts.go 75.00% <0.00%> (+8.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58af143...d0c29f5. Read the comment docs.

@roman-khimov roman-khimov merged commit 52b002e into master Aug 18, 2020
@roman-khimov roman-khimov deleted the check-for-excessive-verification-results branch August 18, 2020 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants