Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc/request: support passing accounts as addresses #2072

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

roman-khimov
Copy link
Member

Turns out, it's completely legal in C#, see neo-project/neo#2543.

Turns out, it's completely legal in C#, see neo-project/neo#2543.
@roman-khimov roman-khimov added bug Something isn't working rpc RPC server and client labels Jul 18, 2021
@roman-khimov roman-khimov added this to the v0.96.0 milestone Jul 18, 2021
@codecov
Copy link

codecov bot commented Jul 18, 2021

Codecov Report

Merging #2072 (a617390) into master (0023c4f) will increase coverage by 16.58%.
The diff coverage is 81.87%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2072       +/-   ##
===========================================
+ Coverage   67.65%   84.24%   +16.58%     
===========================================
  Files         141      287      +146     
  Lines       13163    26904    +13741     
===========================================
+ Hits         8906    22665    +13759     
+ Misses       3849     3010      -839     
- Partials      408     1229      +821     
Impacted Files Coverage Δ
cli/vm/vm.go 60.00% <0.00%> (ø)
pkg/compiler/codegen.go 93.29% <ø> (+5.34%) ⬆️
pkg/compiler/compiler.go 73.88% <ø> (+11.38%) ⬆️
pkg/compiler/debug.go 93.67% <ø> (ø)
pkg/compiler/func_scope.go 100.00% <ø> (ø)
pkg/compiler/inline.go 97.01% <ø> (ø)
pkg/compiler/types.go 85.96% <ø> (ø)
pkg/compiler/vars.go 90.90% <ø> (ø)
pkg/config/config.go 76.92% <ø> (ø)
pkg/config/netmode/netmode.go 83.33% <ø> (ø)
... and 360 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05cb658...a617390. Read the comment docs.

@roman-khimov roman-khimov merged commit 5e26170 into master Jul 19, 2021
@roman-khimov roman-khimov deleted the address-as-account-in-rpc-params branch July 19, 2021 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working rpc RPC server and client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants