Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

native: drop Refuel method from GAS #2111

Merged
merged 1 commit into from
Aug 5, 2021
Merged

native: drop Refuel method from GAS #2111

merged 1 commit into from
Aug 5, 2021

Conversation

roman-khimov
Copy link
Member

It can be used to attack the network (amplifying DOS), so it's broken
beyond repair. See also neo-project/neo#2560 and neo-project/neo#2561.

@roman-khimov roman-khimov added this to the v0.97.1 milestone Aug 5, 2021
It can be used to attack the network (amplifying DOS), so it's broken
beyond repair. This reverts ac60160.

See also neo-project/neo#2560 and neo-project/neo#2561.
@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

Merging #2111 (d6bd6b6) into master (5e18a61) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2111      +/-   ##
==========================================
+ Coverage   84.19%   84.20%   +0.01%     
==========================================
  Files         288      288              
  Lines       27136    27117      -19     
==========================================
- Hits        22848    22835      -13     
+ Misses       3037     3032       -5     
+ Partials     1251     1250       -1     
Impacted Files Coverage Δ
pkg/core/native/native_gas.go 78.46% <ø> (-1.79%) ⬇️
pkg/interop/native/gas/gas.go 0.00% <ø> (ø)
pkg/network/server.go 73.10% <0.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e18a61...d6bd6b6. Read the comment docs.

@roman-khimov roman-khimov merged commit e41fc2f into master Aug 5, 2021
@roman-khimov roman-khimov deleted the drop-refuel branch August 5, 2021 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants