Introduce Genesis protocol setting extensions #3168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3168 +/- ##
==========================================
- Coverage 85.33% 85.29% -0.05%
==========================================
Files 323 326 +3
Lines 43641 43773 +132
==========================================
+ Hits 37242 37335 +93
- Misses 4932 4965 +33
- Partials 1467 1473 +6
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AnnaShaleva
force-pushed
the
roles-init
branch
2 times, most recently
from
0165e2d
to
fb1b808
Compare
And rename roles.go to role.go to match the role_string.go and the existing naming pattern for enums. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
force-pushed
the
roles-init
branch
from
fb1b808
to
73bd227
Compare
|
@roman-khimov, I saw your review and didn't fix it yet, still in progress. Could you, please, review the latest commit? I've just finished it, is it something we'd like to see in our node? If the prototype is OK, then I'll add proper documentation and tests to it. |
AnnaShaleva
commented
Oct 19, 2023
AnnaShaleva
force-pushed
the
roles-init
branch
from
223ea53
to
3d73d54
Compare
AnnaShaleva
force-pushed
the
roles-init
branch
from
3d73d54
to
5be3424
Compare
This section contains genesis-related settings including genesis-related or natives-related extensions. Currently it includes the set of node roles that may be designated duing the native Designation contract initialisation. Close #3156. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
force-pushed
the
roles-init
branch
from
5be3424
to
90f3673
Compare
Provide a script that should be deployed in the genesis block. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
force-pushed
the
roles-init
branch
from
90f3673
to
8cc32a9
Compare
AnnaShaleva
changed the title
|
Ready for review. |
roman-khimov
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3156 and extend it to be able to deploy any script in the genesis. Really nice feature, I like it!
TODO: