services: allow some slippage in TestNotary #3396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Allow 1-block slippage for multisignature request block generation to ensure that PostPersist for fb's NVB-th block is properly finished. 2. Allow 1-block slippage before sent request checks to ensure that PostPersist for NVB fb's NVB-th block was finished and all stale mains were properly marked by Notary service. Overall, this commits ports the approach of #3390 to the whole test. Close #3366. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3396 +/- ##
===========================================
+ Coverage 0 84.85% +84.85%
===========================================
Files 0 331 +331
Lines 0 44968 +44968
===========================================
+ Hits 0 38157 +38157
- Misses 0 5295 +5295
- Partials 0 1516 +1516 ☔ View full report in Codecov by Sentry. |
roman-khimov
approved these changes
Apr 3, 2024
AnnaShaleva
added a commit
that referenced
this pull request
Apr 4, 2024
Close #2956. The failure reason is similar to the one described in #3396 for TestNotary: Blockchain's notificationDispatcher is listening to block events from storeBlock via separate channel. By the moment single block addition is finished, notification may or may not be properly handled by notificationDispatcher, especially given the fact that our runners are slow. As a result, assert.Eventually with 1-second awaiting period may fail. This issue is solved by adding one more block, because the second AddBlock finishes only when it sends block addition event to notificationDispatcher loop, which means that the previous event was handled. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
that referenced
this pull request
Apr 4, 2024
Close #2956. The failure reason is similar to the one described in #3396 for TestNotary: Blockchain's notificationDispatcher is listening to block events from storeBlock via separate channel. By the moment single block addition is finished, notification may or may not be properly handled by notificationDispatcher, especially given the fact that our runners are slow. As a result, assert.Eventually with 1-second awaiting period may fail. This issue is solved by adding one more block, because the second AddBlock finishes only when it sends block addition event to notificationDispatcher loop, which means that the previous event was handled. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall, this commits ports the approach of #3390 to the whole test.
Close #3366.