services: fix race in TestNotary #3390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnnaShaleva
force-pushed
the
fix-notary-test
branch
from
5561a95
to
93e3e1c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3390 +/- ##
==========================================
- Coverage 84.82% 84.80% -0.03%
==========================================
Files 331 331
Lines 44969 44969
==========================================
- Hits 38144 38134 -10
- Misses 5315 5324 +9
- Partials 1510 1511 +1 ☔ View full report in Codecov by Sentry. |
AnnaShaleva
force-pushed
the
fix-notary-test
branch
from
93e3e1c
to
f63b70a
Compare
roman-khimov
reviewed
Apr 1, 2024
AnnaShaleva
force-pushed
the
fix-notary-test
branch
from
f63b70a
to
910f99c
Compare
roman-khimov
reviewed
Apr 2, 2024
Close #3366. Roll back the test structure to the one that it has before d2a7162. Add one extra block to ensure that main transaction won't be finilized. Add NVB increment slippage to avoid race between the first fallback acceptance and block acceptance. Add NVB increment slippage to the rest of fallbacks for test structure unification. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
force-pushed
the
fix-notary-test
branch
from
910f99c
to
f95004a
Compare
roman-khimov
approved these changes
Apr 2, 2024
AnnaShaleva
added a commit
that referenced
this pull request
Apr 3, 2024
1. Allow 1-block slippage for multisignature request block generation to ensure that PostPersist for fb's NVB-th block is properly finished. 2. Allow 1-block slippage before sent request checks to ensure that PostPersist for NVB fb's NVB-th block was finished and all stale mains were properly marked by Notary service. Overall, this commits ports the approach of #3390 to the whole test. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
that referenced
this pull request
Apr 3, 2024
1. Allow 1-block slippage for multisignature request block generation to ensure that PostPersist for fb's NVB-th block is properly finished. 2. Allow 1-block slippage before sent request checks to ensure that PostPersist for NVB fb's NVB-th block was finished and all stale mains were properly marked by Notary service. Overall, this commits ports the approach of #3390 to the whole test. Close #3366. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3366. Roll back the test structure to the one that it has before d2a7162. Add one extra block to ensure that main transaction won't be finilized. Add NVB increment slippage to avoid race between the first fallback acceptance and block acceptance.