-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WS-based RPC server tests fail on Windows #3378
Comments
tried the same approach as the one used in #3368 here and had the same Run tests (windows-2022, 1.22) https://github.com/nspcc-dev/neo-go/compare/dc9b9c0cdf1585bcc734e7ab210c607e27d5235b..e10c584d422d3997b68128231f05a0c68e67aa49 |
Add closing of the server,as it does in others subscription tests. Close #3378 Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
Add closing of the server, as it does in other subscription tests. Close #3378 Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
Close #3378. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Close #3378. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Close #3378. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Not fixed, still have it on Windows, failure discovered in #3387
|
Still not fixed on fresh master, failure discovered in #3396 test run:
From what I see, cleanup problem is not solved.
And cleanup routine from
We need to find out what is the reason of |
A very similar error is discovered in #3397's Windows test failure in
|
Do not wait until wsReader routine gracefully finishes its work before WS connection close. Instead, firstly close the connection, and after that wait for proper wsReader exit. It's a harsh way, but I don't have any other options to try, because wsReader routine hangs on `ws.ReadMessage()` operation for more than ReadDeadline (more than 5 seconds) during test cleanup which results in the test timeout. Close #3378. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Do not wait until wsReader routine gracefully finishes its work before WS connection close. Instead, firstly close the connection, and after that wait for proper wsReader exit. It's a harsh way, but I don't have any other options to try, because wsReader routine hangs on `ws.ReadMessage()` operation for more than ReadDeadline (more than 5 seconds) during test cleanup which results in the test timeout. Close #3378. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Do not wait until wsReader routine gracefully finishes its work before WS connection close. Instead, firstly close the connection, and after that wait for proper wsReader exit. It's a harsh way, but I don't have any other options to try, because wsReader routine hangs on `ws.ReadMessage()` operation for more than ReadDeadline (more than 5 seconds) during test cleanup which results in the test timeout. Close #3378. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
TestFilteredNotaryRequestSubscriptions
fails on Windows
So the group of tests is affected, not only |
Go 1.22, Windows, e10c584. The failure error
read tcp 127.0.0.1:59625->127.0.0.1:59624: i/o timeout
looks exactly like in the previously failingTestRPC
(#3314). To solve it we should try the same approach as the one used in #3368.The text was updated successfully, but these errors were encountered: