-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TestNotary ubuntu fails #3366
Labels
Milestone
Comments
AliceInHunterland
added
bug
Something isn't working
test
Unit tests
U2
Seriously planned
S3
Minimally significant
I4
No visible changes
labels
Mar 19, 2024
AliceInHunterland
added a commit
that referenced
this issue
Apr 1, 2024
It is failing sometimes because transaction is being accepted. It happens because executor's chain continuously produces blocks, so occasionally the block is being accepted right after transaction submission. Close ##3366 Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland
added a commit
that referenced
this issue
Apr 1, 2024
It is failing sometimes because transaction is being accepted. It happens because executor's chain continuously produces blocks, so occasionally the block is being accepted right after transaction submission. Close ##3366 Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AnnaShaleva
added a commit
that referenced
this issue
Apr 1, 2024
Close #3366. Roll back the test structure to the one that it has before d2a7162. Add one extra block to ensure that main transaction won't be finilized. Add NVB increment slippage to avoid race between the first fallback acceptance and block acceptance. Add NVB increment slippage to the rest of fallbacks for test structure unification. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
that referenced
this issue
Apr 2, 2024
Close #3366. Roll back the test structure to the one that it has before d2a7162. Add one extra block to ensure that main transaction won't be finilized. Add NVB increment slippage to avoid race between the first fallback acceptance and block acceptance. Add NVB increment slippage to the rest of fallbacks for test structure unification. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
that referenced
this issue
Apr 2, 2024
Close #3366. Roll back the test structure to the one that it has before d2a7162. Add one extra block to ensure that main transaction won't be finilized. Add NVB increment slippage to avoid race between the first fallback acceptance and block acceptance. Add NVB increment slippage to the rest of fallbacks for test structure unification. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
After the fix presented in #3390 this test is failing in the other place (later testcase). Discovered in #3385.
|
AnnaShaleva
added a commit
that referenced
this issue
Apr 3, 2024
1. Allow 1-block slippage for multisignature request block generation to ensure that PostPersist for fb's NVB-th block is properly finished. 2. Allow 1-block slippage before sent request checks to ensure that PostPersist for NVB fb's NVB-th block was finished and all stale mains were properly marked by Notary service. Overall, this commits ports the approach of #3390 to the whole test. Close #3366. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Discovered again after #3404 merge into master (Go 1.21, Ubuntu, https://github.com/nspcc-dev/neo-go/actions/runs/8627442036/job/23647412672), the error is in other place of the test, but the idea is the same:
|
Reproduced in #3441:
|
Reproduced in #3504.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Run tests (ubuntu-22.04, 1.21)
The text was updated successfully, but these errors were encountered: