native: fix Policy's IsBlocked behaviour #3443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Account is blocked when it's in the Policy's storage, not when it's missing from the Policy storage. Introduced in bbbc680. This bug leads to the fact that during native Neo cache initialization at the last block in the dBFT epoch, all candidates accounts are "blocked", and thus, stand-by committee and validators are used in the subsequent new epoch. Close #3424. This bug may lead to the consequences described in #3273, but it needs to be confirmed. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Supply the account with expected balance. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3443 +/- ##
==========================================
+ Coverage 86.12% 86.16% +0.03%
==========================================
Files 331 331
Lines 38442 38442
==========================================
+ Hits 33110 33123 +13
+ Misses 3804 3795 -9
+ Partials 1528 1524 -4 ☔ View full report in Codecov by Sentry. |
Probably that will be easier to check than the node restart. So if an elected committee drives the network, and then occasionally (without voting or NEO transfer transactions) the "faulty" node starts to reward stand-by accounts in OnPersist/PostPersist (may be checked by Transfer notifications for blocks applog), then that's the case. |
roman-khimov
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Account is blocked when it's in the Policy's storage, not when it's missing from the storage. Introduced in bbbc680.
This bug leads to the fact that during native Neo cache initialization at the last block in the dBFT epoch, all candidates accounts are "blocked", and thus, stand-by committee and validators are used in the subsequent new epoch. Close #3424.
This bug may lead to the consequences described in #3273, but it needs to be confirmed. @fyfyrchik, is it possible for your network to check whether "faulty" node has been restarted in the last block of some dBFT epoch? And then check what the receivers of block rewards in the next dBFT epoch are stand-by validators/committee. If so, then the problem is the same, since this bug leads to the wrong block reward distribution (to stand-by committee instead of elected committee) which may result in the failing OnPersist script if, for example, the sender of some in-block transaction is an elected committee member or validator.