core: sort GetValidators() result #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As C# node does it. Technically it's only needed for consensus and could be implemented in the appropriate package, but for better compatibility with C# node we're better returning it sorted right here.
roman-khimov
force-pushed
the
sort-validator-keys
branch
from
03fb13a
to
d4cd134
Compare
Codecov Report
@@ Coverage Diff @@
## master #664 +/- ##
==========================================
- Coverage 64.84% 64.83% -0.01%
==========================================
Files 125 125
Lines 10607 10608 +1
==========================================
Hits 6878 6878
- Misses 3450 3451 +1
Partials 279 279 Continue to review full report at Codecov.
|
fyrchik
approved these changes
Feb 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As C# node does it. Technically it's only needed for consensus and could be
implemented in the appropriate package, but for better compatibility with C#
node we're better returning it sorted right here.