Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON tags for RPC response types #666

Merged
merged 1 commit into from
Feb 13, 2020

Conversation

im-kulikov
Copy link
Contributor

@im-kulikov im-kulikov commented Feb 13, 2020

- Attribute should have 2 fields (usage, data)
- VOut should have 4 (5) fields (asset, value, address, n)
- Script should have 2 fields (invocation, verification)
@im-kulikov im-kulikov added the rpc RPC server and client label Feb 13, 2020
@im-kulikov im-kulikov self-assigned this Feb 13, 2020
@codecov
Copy link

codecov bot commented Feb 13, 2020

Codecov Report

Merging #666 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #666   +/-   ##
=======================================
  Coverage   64.85%   64.85%           
=======================================
  Files         125      125           
  Lines       10609    10609           
=======================================
  Hits         6880     6880           
  Misses       3450     3450           
  Partials      279      279
Impacted Files Coverage Δ
pkg/core/transaction/witness.go 46.15% <ø> (ø) ⬆️
pkg/core/transaction/attribute.go 30.95% <ø> (ø) ⬆️
pkg/core/transaction/output.go 40% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8a8dc9...8d410a6. Read the comment docs.

@roman-khimov roman-khimov added the bug Something isn't working label Feb 13, 2020
@roman-khimov roman-khimov added this to the v0.72.3 milestone Feb 13, 2020
@im-kulikov im-kulikov merged commit 2aaeb7f into master Feb 13, 2020
@im-kulikov im-kulikov deleted the add-json-tags-for-rpc-response branch February 13, 2020 16:15
@roman-khimov roman-khimov modified the milestones: v0.72.3, v0.73.0 Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working rpc RPC server and client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants