cli: implement wallet import/export functionality #685

fyrchik · 2020-02-20T13:17:47Z

Support some of the capabilities outlined in #26 .

import WIF
import WIF + multisig
export WIF

Fix some minor bugs.

They are set during account creation and open+decrypt is expected to put account in the same state.

When we are opening a file, it is expected that it will be rewritten, not appended to a already existing wallet.

codecov · 2020-02-20T13:20:26Z

Codecov Report

Merging #685 into master will increase coverage by 0.03%.
The diff coverage is 78%.

@@            Coverage Diff             @@
##           master     #685      +/-   ##
==========================================
+ Coverage   65.01%   65.05%   +0.03%     
==========================================
  Files         125      125              
  Lines       10820    10869      +49     
==========================================
+ Hits         7035     7071      +36     
- Misses       3505     3516      +11     
- Partials      280      282       +2

Impacted Files	Coverage Δ
pkg/smartcontract/param_context.go	`76.02% <0%> (-4.23%)`	⬇️
pkg/wallet/account.go	`93.33% <100%> (+0.88%)`	⬆️
pkg/wallet/wallet.go	`78.46% <33.33%> (-2.19%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cad1f07...2fc6375. Read the comment docs.

Also do not ignore errors from `terminal.ReadPassword`.

(*Account).ConvertMultisig() will convert an existing account into a multisig one.

cli/wallet/wallet.go

roman-khimov · 2020-02-21T08:59:05Z

One thing we're missing here: newAccountFromPrivateKey should also generate a simple CHECKSIG contract, that actually was one of the issues with our testnet CN, it had a key in the wallet, but it didn't have a contract accociated with it and then GetAccount() failed to find the key because its operation is based on contracts.

roman-khimov · 2020-02-21T09:00:38Z

Other than that it's fine, we may probably tune the cli part of it, but the main thing is that all of the functionality is there.

fyrchik · 2020-02-21T09:06:31Z

@roman-khimov is it somehow different from what is done in 5a727ca ?

One positional argument can be provided. If so, it is interpreted as address and only WIFs corresponding to it are exported. If address is provided '--decrypt' flag can be specified to export unencrypted WIFs.

roman-khimov · 2020-02-21T09:20:20Z

Yeah, that's what it is, somehow I've missed that this change actually fixes newAccountFromPrivateKey.

fyrchik added 5 commits February 20, 2020 15:52

cli: declare wallet path flag once

0295428

wallet: allow to create accounts from encrypted WIFs

d837eb3

wallet: set WIF and public key on account decrypt

ad6fa2a

They are set during account creation and open+decrypt is expected to put account in the same state.

wallet: rewrite file on save

ea30122

When we are opening a file, it is expected that it will be rewritten, not appended to a already existing wallet.

smartcontract: implement json.Unmarshaler for ParamType

eacea8b

fyrchik added 4 commits February 21, 2020 10:45

wallet: add signature check contracts to new accounts

5a727ca

cli: move password getting to a separate function

a71c2c4

Also do not ignore errors from `terminal.ReadPassword`.

cli: implement wallet WIF import

baa68e1

wallet: support creating multisig accounts

25ffb56

(*Account).ConvertMultisig() will convert an existing account into a multisig one.

roman-khimov reviewed Feb 21, 2020

View reviewed changes

cli/wallet/wallet.go Outdated Show resolved Hide resolved

roman-khimov reviewed Feb 21, 2020

View reviewed changes

cli/wallet/wallet.go Outdated Show resolved Hide resolved

fyrchik added 4 commits February 21, 2020 12:14

cli: implement multisig import to wallet

a030411

cli: implement wallet WIF/NEP2 export

20c9841

One positional argument can be provided. If so, it is interpreted as address and only WIFs corresponding to it are exported. If address is provided '--decrypt' flag can be specified to export unencrypted WIFs.

cli: support account creation in existing wallet

3d67d52

cli: provide separate function for opening wallet

2fc6375

roman-khimov added this to the v0.74.0 milestone Feb 21, 2020

roman-khimov approved these changes Feb 21, 2020

View reviewed changes

roman-khimov merged commit ef31d0d into master Feb 21, 2020

roman-khimov deleted the feature/wallet branch February 21, 2020 09:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cli: implement wallet import/export functionality #685

cli: implement wallet import/export functionality #685

fyrchik commented Feb 20, 2020

codecov bot commented Feb 20, 2020 •

edited

Loading

roman-khimov commented Feb 21, 2020

roman-khimov commented Feb 21, 2020

fyrchik commented Feb 21, 2020 •

edited

Loading

roman-khimov commented Feb 21, 2020

cli: implement wallet import/export functionality #685

cli: implement wallet import/export functionality #685

Conversation

fyrchik commented Feb 20, 2020

codecov bot commented Feb 20, 2020 • edited Loading

Codecov Report

roman-khimov commented Feb 21, 2020

roman-khimov commented Feb 21, 2020

fyrchik commented Feb 21, 2020 • edited Loading

roman-khimov commented Feb 21, 2020

codecov bot commented Feb 20, 2020 •

edited

Loading

fyrchik commented Feb 21, 2020 •

edited

Loading