Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Claim TX verification for mempool #697

Merged
merged 2 commits into from
Feb 27, 2020
Merged

Conversation

roman-khimov
Copy link
Member

Problem

Potential double claims.

Uncovered by TestMemPoolAddRemoveWithInputsAndClaims (to be added later)
Use more efficient check for Input and also check Claims to avoid double
claiming.
@roman-khimov roman-khimov added this to the v0.74.0 milestone Feb 27, 2020
@codecov
Copy link

codecov bot commented Feb 27, 2020

Codecov Report

Merging #697 into master will increase coverage by 0.13%.
The diff coverage is 96.77%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #697      +/-   ##
=========================================
+ Coverage   65.76%   65.9%   +0.13%     
=========================================
  Files         128     128              
  Lines       10916   10965      +49     
=========================================
+ Hits         7179    7226      +47     
- Misses       3456    3457       +1     
- Partials      281     282       +1
Impacted Files Coverage Δ
pkg/core/transaction/input.go 100% <100%> (ø) ⬆️
pkg/core/mempool/mem_pool.go 97.09% <96.42%> (-0.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d59fa0...3e2b490. Read the comment docs.

@roman-khimov roman-khimov merged commit 26c4e83 into master Feb 27, 2020
@roman-khimov roman-khimov deleted the claim-verification-in-mempool branch February 27, 2020 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants