Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smartcontract: fix bugs in paramter marshal/unmarshal #719

Merged
merged 2 commits into from
Mar 4, 2020
Merged

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Mar 4, 2020

  1. adjust values to types properly
  2. allow to marshal nil byte slices

@codecov
Copy link

codecov bot commented Mar 4, 2020

Codecov Report

Merging #719 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #719      +/-   ##
==========================================
- Coverage   64.03%   64.03%   -0.01%     
==========================================
  Files         132      132              
  Lines       11696    11695       -1     
==========================================
- Hits         7490     7489       -1     
  Misses       3913     3913              
  Partials      293      293
Impacted Files Coverage Δ
pkg/smartcontract/param_context.go 75.2% <100%> (+0.3%) ⬆️
pkg/smartcontract/param_type.go 91.39% <100%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8141d49...b4f8d66. Read the comment docs.

@roman-khimov roman-khimov added this to the v0.74.0 milestone Mar 4, 2020
@roman-khimov roman-khimov merged commit 1dd7c8d into master Mar 4, 2020
@roman-khimov roman-khimov deleted the fix/rpc branch March 4, 2020 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smartcontract Smart contracts and associated package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants