-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core,rpc: implement NEP5-related logic #723
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VM can produce both big.Int and []byte because they are converted to each other on demand.
Codecov Report
@@ Coverage Diff @@
## master #723 +/- ##
==========================================
+ Coverage 66.47% 66.73% +0.26%
==========================================
Files 134 135 +1
Lines 11895 12127 +232
==========================================
+ Hits 7907 8093 +186
- Misses 3625 3643 +18
- Partials 363 391 +28
Continue to review full report at Codecov.
|
roman-khimov
requested changes
Mar 5, 2020
roman-khimov
reviewed
Mar 5, 2020
Also transfer tokens between accounts.
Every NEP5 contract MUST have `decimals` method which is used to properly display token amount.
When changing test chain it can be rather annoying to replace all of the occurences of the contract hash.
roman-khimov
approved these changes
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getnep5balances
andgetnep5transfers
RPC.Closes #498 .