Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contract description limit #736

Merged
merged 2 commits into from
Mar 10, 2020
Merged

Conversation

roman-khimov
Copy link
Member

Problem

#735.

Obvious bug that hides failed contract deployments.
It differs from other parameters in C# code. Fixes #735.
@codecov
Copy link

codecov bot commented Mar 9, 2020

Codecov Report

Merging #736 into master will not change coverage by %.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #736   +/-   ##
=======================================
  Coverage   66.66%   66.66%           
=======================================
  Files         136      136           
  Lines       12256    12256           
=======================================
  Hits         8171     8171           
  Misses       3689     3689           
  Partials      396      396           
Impacted Files Coverage Δ
pkg/core/interop_neo.go 59.61% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b83e9a...eb404ce. Read the comment docs.

@roman-khimov roman-khimov merged commit cc8203f into master Mar 10, 2020
@roman-khimov roman-khimov deleted the fix-contract-description-limit branch March 10, 2020 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants