Use wallet in smartcontract deploy/invoke commands and calculate GAS properly #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That's how it was intended to behave originally. One thing questionable here is contract price (policy thing, basically) being moved to smartcontract package, but it's probably fine for NEO 2.0 (as it won't change) and we'll make something better for NEO 3.0.
Codecov Report
@@ Coverage Diff @@
## master #747 +/- ##
=========================================
- Coverage 66.12% 66.02% -0.1%
=========================================
Files 138 139 +1
Lines 12404 12413 +9
=========================================
- Hits 8202 8196 -6
- Misses 3807 3822 +15
Partials 395 395
Continue to review full report at Codecov.
|
fyrchik
approved these changes
Mar 12, 2020
Passing WIF directly in the command line is not something we should be doing. Also split netfee and sysfee in the RPC as they're different (and add a script attribute for free transactions).
roman-khimov
force-pushed
the
fix-contract-deploy-gas-parameter
branch
from
000020b
to
25da5a3
Compare
AnnaShaleva
approved these changes
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Real GAS needed to deploy smartcontract was not calculated, so one could only try different GAS values to see which one fits. Wallets were also not integrated properly into this part of the CLI.