cli: implement Fixed8Flag #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #752 +/- ##
==========================================
+ Coverage 64.80% 64.84% +0.04%
==========================================
Files 141 141
Lines 12790 12779 -11
==========================================
- Hits 8288 8286 -2
+ Misses 4097 4091 -6
+ Partials 405 402 -3
Continue to review full report at Codecov.
|
roman-khimov
requested changes
Mar 16, 2020
Parsing gas from float value is not always a right idea as a transform from float is not 1-to-1. This commit implements Fixed8Flag which parses Fixed8 value from string.
roman-khimov
approved these changes
Mar 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed8from string in cli instead of float.transaction.AddVerificationHash()for convenience.