Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm: fix offset for CALLI opcode #791

Merged
merged 1 commit into from
Mar 26, 2020
Merged

vm: fix offset for CALLI opcode #791

merged 1 commit into from
Mar 26, 2020

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Mar 25, 2020

It is different from other JMP* and
+2 should be added to paramter.
Related #452 .
https://github.com/neo-project/neo-vm/blob/master-2.x/src/neo-vm/ExecutionEngine.cs#L1175

@codecov
Copy link

codecov bot commented Mar 25, 2020

Codecov Report

Merging #791 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #791   +/-   ##
=======================================
  Coverage   66.75%   66.75%           
=======================================
  Files         141      141           
  Lines       12963    12963           
=======================================
  Hits         8654     8654           
  Misses       3899     3899           
  Partials      410      410
Impacted Files Coverage Δ
pkg/vm/vm.go 78.01% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f65e19...4522eed. Read the comment docs.

@roman-khimov roman-khimov added the vm VM tasks/bugs/issues label Mar 26, 2020
@roman-khimov roman-khimov added this to the v0.74.1 milestone Mar 26, 2020
@roman-khimov
Copy link
Member

Likely to be the fix for #798.

It is different from other JMP* and +2 should be added to the parameter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working vm VM tasks/bugs/issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants