Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: allow to unmarshal integer params from string #794

Merged
merged 1 commit into from
Mar 25, 2020
Merged

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Mar 25, 2020

Parameters can be sent as string.
Related #774.

@codecov
Copy link

codecov bot commented Mar 25, 2020

Codecov Report

Merging #794 into master will decrease coverage by 0.00%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #794      +/-   ##
==========================================
- Coverage   66.76%   66.75%   -0.01%     
==========================================
  Files         141      141              
  Lines       12961    12963       +2     
==========================================
+ Hits         8653     8654       +1     
- Misses       3898     3899       +1     
  Partials      410      410              
Impacted Files Coverage Δ
pkg/rpc/request/param.go 95.77% <80.00%> (-1.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f26064...4e92642. Read the comment docs.

@roman-khimov roman-khimov added this to the v0.74.1 milestone Mar 25, 2020
@roman-khimov roman-khimov merged commit e5fbf3e into master Mar 25, 2020
@roman-khimov roman-khimov deleted the fix/rpc branch March 25, 2020 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working rpc RPC server and client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants