Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples: expand storage smartcontract with find() usage example #795

Merged
merged 2 commits into from
Mar 26, 2020
Merged

examples: expand storage smartcontract with find() usage example #795

merged 2 commits into from
Mar 26, 2020

Conversation

AnnaShaleva
Copy link
Member

closes #364

@AnnaShaleva AnnaShaleva added the feature Completely new functionality label Mar 25, 2020
@AnnaShaleva AnnaShaleva added this to the v0.74.1 milestone Mar 25, 2020
@AnnaShaleva AnnaShaleva self-assigned this Mar 25, 2020
@codecov
Copy link

codecov bot commented Mar 25, 2020 •
edited
Loading

Codecov Report

Merging #795 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #795   +/-   ##
=======================================
  Coverage   66.76%   66.76%           
=======================================
  Files         141      141           
  Lines       12964    12964           
=======================================
  Hits         8655     8655           
  Misses       3899     3899           
  Partials      410      410

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a262c6...0a5298b. Read the comment docs.

@roman-khimov roman-khimov removed this from the v0.74.1 milestone Mar 25, 2020
@AnnaShaleva AnnaShaleva force-pushed the feature/find_storage_example branch 6 times, most recently from 62da7a2 to d849daa Compare March 26, 2020 12:32
roman-khimov
roman-khimov requested changes Mar 26, 2020
View reviewed changes
Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And please make a separate commit for compiler/interop changes.

pkg/compiler/syscall.go Show resolved Hide resolved
pkg/interop/iterator/iterator.go Show resolved Hide resolved
@AnnaShaleva
compiler/interop: add missing methods to interop.Iterator
37cb60a 
Add Next() and Value() to interop.Iterator and corresponding syscalls to
compiler
@roman-khimov roman-khimov merged commit d462276 into master Mar 26, 2020
@roman-khimov roman-khimov deleted the feature/find_storage_example branch March 26, 2020 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fyrchik fyrchik fyrchik left review comments

@roman-khimov roman-khimov roman-khimov approved these changes

Assignees

@AnnaShaleva AnnaShaleva

Labels
feature Completely new functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expand storage smartcontract with find() usage example
3 participants
@AnnaShaleva @fyrchik @roman-khimov