Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vm: update stack size in SETITEM properly #973

Merged
merged 1 commit into from
May 21, 2020
Merged

vm: update stack size in SETITEM properly #973

merged 1 commit into from
May 21, 2020

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented May 21, 2020

Fix a typo.

@codecov
Copy link

codecov bot commented May 21, 2020 •
edited
Loading

Codecov Report

Merging #973 into master-2.x will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           master-2.x     #973      +/-   ##
==============================================
- Coverage       68.00%   67.99%   -0.02%     
==============================================
  Files             145      145              
  Lines           14305    14305              
==============================================
- Hits             9728     9726       -2     
- Misses           4117     4119       +2     
  Partials          460      460
Impacted Files Coverage Δ
pkg/vm/vm.go 86.65% <100.00%> (ø)
pkg/rpc/client/wsclient.go 84.35% <0.00%> (-1.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0853c0...cd8445a. Read the comment docs.

roman-khimov
roman-khimov approved these changes May 21, 2020
View reviewed changes
Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please port it to master.

@roman-khimov roman-khimov added this to the v0.75.0 milestone May 21, 2020
@roman-khimov roman-khimov merged commit e07fd4f into master-2.x May 21, 2020
@roman-khimov roman-khimov deleted the fix/refcount branch May 21, 2020 13:47
@fyrchik fyrchik mentioned this pull request May 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman-khimov roman-khimov roman-khimov approved these changes

Assignees
No one assigned
Labels
bug Something isn't working vm VM tasks/bugs/issues
Projects
None yet
Milestone
v0.75.0
Development

Successfully merging this pull request may close these issues.
2 participants
@fyrchik @roman-khimov