Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Go #444

Merged
merged 4 commits into from
Feb 27, 2024
Merged

Bump Go #444

merged 4 commits into from
Feb 27, 2024

Conversation

cthulhu-rider
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 51.58%. Comparing base (5fe4f10) to head (6eb891d).

Files Patch % Lines
netmap/attributes.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #444       +/-   ##
===========================================
- Coverage   63.60%   51.58%   -12.03%     
===========================================
  Files          76      159       +83     
  Lines        9573    19840    +10267     
===========================================
+ Hits         6089    10234     +4145     
- Misses       2758     8834     +6076     
- Partials      726      772       +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

roman-khimov
roman-khimov previously approved these changes Feb 27, 2024
Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not found anything to change here after a quick search.

@roman-khimov
Copy link
Member

I'm not sure why linter fails though and actions deserve an update as well.

The age of Go 1.19 is over: Go 1.22 has come.

New func `strings.CutPrefix` replaces `strings.TrimPrefix` + check. Func
`math.Rand.Seed` was marked as deprecated, but used for test code only.

Closes #441.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Made similar to the same action in Neo Go and NeoFS Contracts projects.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
@cthulhu-rider cthulhu-rider merged commit fb2ed14 into master Feb 27, 2024
5 of 7 checks passed
@cthulhu-rider cthulhu-rider deleted the upd/go branch February 27, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants