-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store large objects hashes in the link object payload #263
Comments
overall looks good, but
will tie our hands on a potentially necessary expansion of the format in the future. If for some reason there is no desire to define a clear structure of this data (which I consider more like saving on matches than justified), then let's leave at least the 1st byte as a marker: let 0 mean hash concatenation |
This can be tied to the version of the object itself. |
really can, I don’t think it’s more convenient, but it’s better than nothing |
See also #264. |
It describes future protocol version's link object payload. Child objects list will be moved from the header to the payload. This is done due to the header size restrictions. Closes #263. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
It describes future protocol version's link object payload. Child objects list will be moved from the header to the payload. This is done due to the header size restrictions. Closes #263. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
It describes future protocol version's link object payload. Child objects list will be moved from the header to the payload. This is done due to the header size restrictions. Closes #263. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
It describes future protocol version's link object payload. Child objects list will be moved from the header to the payload. This is done due to the header size restrictions. Closes #263. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
It describes future protocol version's link object payload. Child objects list will be moved from the header to the payload. This is done due to the header size restrictions. Closes #263. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
We can't break old objects, so split header can still remain (and arguably it can be more effective for smaller objects with 2-50 parts), but we need a new link object format with hashes stored in its payload. We can even do this without many changes to the wire protocol, just specify that missing "children" list means that hashes are encoded in the payload. Encode them without any wrappers, plain 32 bytes values one by one.
The text was updated successfully, but these errors were encountered: