Fix/Clarify container removal #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
|
Shouldn't we decide on container lock/hold procedure first? |
Yes, lets discuss it first and then correct that PR according to the decision. |
|
Note: In S3 API you can't remove a non-empty bucket, hence there is no such issue. In NeoFS we can't check container content on DELETE operation, so some additional container lock/hold mechanism is required. Related: nspcc-dev/neofs-contract#247 |
|
The PR describes the way things work now and having this documentation is better than not having it. If the way things work is to change, we'll change the documentation accordingly. |
roman-khimov
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.