Correct getcontainersize api #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, we can't check for more. Epoch number is serialized in a way that is dynamic in size. Signed-off-by: Roman Khimov <roman@nspcc.ru>
This commit hijacks iterateContainerSizes for container-specific estimations and keeps iterateAllContainerSizes with a bit better behaviour in that it strips useless key prefix. This API is not yet released and is not used anywhere, so this can be done safely. Signed-off-by: Roman Khimov <roman@nspcc.ru>
It's a part of the public API. Signed-off-by: Roman Khimov <roman@nspcc.ru>
Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
force-pushed
the
correct-getcontainersize-api
branch
from
8f36843
to
e930972
Compare
cthulhu-rider
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to include this into 0.17.0 to have something for the nspcc-dev/neofs-node#2173 to use.