container: Check eACL input in setEACL method's implementation
#330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cthulhu-rider
commented
Apr 10, 2023
•
cthulhu-rider
commented
- relates Responsive panic about invalid user input during contract execution #329
Previously `setEACL` method could throw `invalid offset` fault exception about invalid eACL argument. This message is too generic, may occur in different places of execution code and doesn't help caller to realize the reason. To improve user experience, it's worth to check method arguments before slice instructions. Pre-check `eACL` slice length in `SetEACL` method implementation and throw responsive panic message. Ref nspcc-dev#329. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
`SetEACL` method imposes requirements on the eACL parameter of a generic byte array type. These requirements should be described in the documentation as user manual. Ref nspcc-dev#329. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
roman-khimov
approved these changes
Apr 10, 2023
AnnaShaleva
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.