nns: Add records' iterating method to the list of safe ones #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method was presented in the `nns.yml` file while missing in the `config.yml` one since its inception. Add `getAllRecords` elements to the `safemethods` list in the configuration file. As a consequence, corresponding methods are now exported from the contract reader (`nns.ContractReader` type) and dropped from the transaction maker (`nns.Contract` type). Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
requested review from
carpawell and
roman-khimov
as code owners
roman-khimov
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.