-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NNS migration to 0.18.0 #357
Conversation
There were some misses in previous commits. Signed-off-by: Roman Khimov <roman@nspcc.ru>
We're no longer 0.17.0, we're not yet 0.18.0, but to be able to properly test upgrades we need some newer version. Signed-off-by: Roman Khimov <roman@nspcc.ru>
Hiding it doesn't help in any way and just limits our abilities. Signed-off-by: Roman Khimov <roman@nspcc.ru>
And appropriate interops. Signed-off-by: Roman Khimov <roman@nspcc.ru>
We've never tested NNS and can't even create dumps for by default. But it differs a bit from regular contracts and the easiest way to handle is just to have some additional mode. Signed-off-by: Roman Khimov <roman@nspcc.ru>
8b96646
to
daeaaaf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise.
@@ -4,16 +4,22 @@ Changelog for NeoFS Contract | |||
## [Unreleased] | |||
|
|||
### Added | |||
- EACL validation in container.setEACL (#330) | |||
- Contract storage model documentation (#320) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how do you define the capitalization of the first word? (my vote is for a capital one, but they should be synced at least)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does "Contract" mean here? why is it "Contract" but the others are "ability", "bump" and so on?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added... some kind of documentation.
An omission of #344. Signed-off-by: Roman Khimov <roman@nspcc.ru>
daeaaaf
to
a07db31
Compare
No description provided.