NNS migration to 0.18.0 #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were some misses in previous commits. Signed-off-by: Roman Khimov <roman@nspcc.ru>
We're no longer 0.17.0, we're not yet 0.18.0, but to be able to properly test upgrades we need some newer version. Signed-off-by: Roman Khimov <roman@nspcc.ru>
Hiding it doesn't help in any way and just limits our abilities. Signed-off-by: Roman Khimov <roman@nspcc.ru>
And appropriate interops. Signed-off-by: Roman Khimov <roman@nspcc.ru>
We've never tested NNS and can't even create dumps for by default. But it differs a bit from regular contracts and the easiest way to handle is just to have some additional mode. Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
requested review from
carpawell and
cthulhu-rider
as code owners
roman-khimov
force-pushed
the
nns-migration
branch
3 times, most recently
from
8b96646
to
daeaaaf
Compare
carpawell
reviewed
Sep 22, 2023
| @@ -4,16 +4,22 @@ Changelog for NeoFS Contract | |||
| ## [Unreleased] | |||
|
|
|||
| ### Added | |||
| - EACL validation in container.setEACL (#330) | |||
| - Contract storage model documentation (#320) | |||
There was a problem hiding this comment.
how do you define the capitalization of the first word? (my vote is for a capital one, but they should be synced at least)
There was a problem hiding this comment.
what does "Contract" mean here? why is it "Contract" but the others are "ability", "bump" and so on?
There was a problem hiding this comment.
Added... some kind of documentation.
An omission of #344. Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
force-pushed
the
nns-migration
branch
from
daeaaaf
to
a07db31
Compare
AnnaShaleva
approved these changes
Sep 25, 2023
cthulhu-rider
approved these changes
Sep 26, 2023
carpawell
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.