scripts: add compare-deposits for quick main/fs chain comparisons #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roman-khimov
force-pushed
the
compare-deposits
branch
from
7f219ea
to
7dd46cd
Compare
AnnaShaleva
reviewed
Jun 12, 2024
| "github.com/urfave/cli" | ||
| ) | ||
|
|
||
| var errStateMatches = errors.New("state matches") |
There was a problem hiding this comment.
And BTW, this error is unused, just remove it.
roman-khimov
force-pushed
the
compare-deposits
branch
from
7dd46cd
to
63e5179
Compare
Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
force-pushed
the
compare-deposits
branch
from
63e5179
to
81c06d7
Compare
cthulhu-rider
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
good overall, i wont dive into the code deeply according to #400 (comment)
| neoFSContract := c.Args().Get(1) | ||
| rpcFS := c.Args().Get(2) | ||
| if rpcMain == "" { | ||
| return errors.New("no arguments given") |
There was a problem hiding this comment.
wont be very true with "" hello world input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.