Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize Head in writecache #1149

Closed
fyrchik opened this issue Feb 8, 2022 · 0 comments · Fixed by #1280
Closed

Optimize Head in writecache #1149

fyrchik opened this issue Feb 8, 2022 · 0 comments · Fixed by #1280
Assignees
@fyrchik
Milestone
v0.28.0

Comments

@fyrchik
Copy link
Contributor

fyrchik commented Feb 8, 2022

neofs-node/pkg/local_object_storage/writecache/get.go

Line 46 in 1667ec9

// TODO: easiest to implement solution is presented here, consider more efficient way, e.g.:

Currently we use Get, discuss and benchmark whether an optimization is worth it.
@fyrchik fyrchik mentioned this issue Mar 31, 2022
Merged
aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue Oct 19, 2022
@fyrchik @aprasolova
[nspcc-dev#1149] writecache: Prevent corruption in Head
2e2d3be 
Also, remove optimization comments:
1. Having to maintain an execute the same logic for headers as for
   objects is quite inefficient, as it increases memory footprint.
2. Unmarshaling object is a cheap operation if data slice is in memory.
3. For unmarshaling header-only, I think we need SDK support.

Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fyrchik fyrchik

Labels
None yet
Projects
None yet
Milestone
v0.28.0
Development

Successfully merging a pull request may close this issue.

[#1149] writecache: Prevent corruption in Head fyrchik/neofs-node
2 participants
@alexvanin @fyrchik