Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support interaction with tree service from neofs-cli #1332

Open
4 of 9 tasks
Tracked by #1322
fyrchik opened this issue Apr 25, 2022 · 3 comments
Open
4 of 9 tasks
Tracked by #1322

Support interaction with tree service from neofs-cli #1332

fyrchik opened this issue Apr 25, 2022 · 3 comments
Labels
blocked Can't be done because of something feature Completely new functionality I2 Regular impact neofs-cli NeoFS CLI application issues S4 Routine

Comments

@fyrchik
Copy link
Contributor

fyrchik commented Apr 25, 2022

  • Add
  • AddByPath
  • Remove
  • Move
  • GetNodeByPath
  • GetSubTree
  • Healthcheck
  • GetOpLog
  • ListTrees
@fyrchik fyrchik mentioned this issue Apr 25, 2022
23 tasks
@carpawell
Copy link
Member

carpawell commented Aug 11, 2022

All the Tree Service RPCs should have corresponding CLI commands. Apply is an exception.

@carpawell carpawell removed the triage label Aug 11, 2022
@carpawell carpawell modified the milestones: v0.32.0, v0.31.1 Aug 11, 2022
@acid-ant
Copy link
Contributor

How about common command for the whole list of services on node? Like this:

@:~/workspace/neofs-node$ neofs-cli --rpc-endpoint 192.168.130.71:8080  node services
tree service status: N/A
@:~/workspace/neofs-node$ neofs-cli --rpc-endpoint 192.168.130.71:8080  node services
tree service status: available
@:~/workspace/neofs-node$

@carpawell carpawell added 2022Q4 and removed 2022Q3 labels Oct 10, 2022
@carpawell carpawell self-assigned this Oct 12, 2022
carpawell added a commit that referenced this issue Oct 13, 2022
It will allow reusing signing routine in other components
(e.g. `neofs-cli`).

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell added a commit that referenced this issue Oct 13, 2022
It is `TreeService.Add` method implementation.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell added a commit that referenced this issue Oct 13, 2022
It is `TreeService.GetNodeByPath` method implementation.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell added a commit that referenced this issue Oct 13, 2022
It is `TreeService.AddNodeByPath` method implementation.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell added a commit that referenced this issue Oct 13, 2022
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell added a commit that referenced this issue Oct 13, 2022
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue Oct 19, 2022
It will allow reusing signing routine in other components
(e.g. `neofs-cli`).

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue Oct 19, 2022
It is `TreeService.Add` method implementation.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue Oct 19, 2022
It is `TreeService.GetNodeByPath` method implementation.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue Oct 19, 2022
It is `TreeService.AddNodeByPath` method implementation.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue Oct 19, 2022
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue Oct 19, 2022
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell added a commit that referenced this issue Oct 20, 2022
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@vkarak1
Copy link

vkarak1 commented Nov 2, 2022

There are several suggestions / comments which could help to make life better to work with tree service:

  1. It would be great to see details in neofs-storage service log regarding tree syncing, for now I was able to see only the following types of messages:
debug        tree/sync.go:280        syncing container trees...        {"cid": "5S1mE1yrhm7Ww3JEiWSazTwJbDCvDwyqYB6bSpmnmy9N
debug        tree/sync.go:291        container trees have been synced        {"cid": "5S1mE1yrhm7Ww3JEiWSazTwJbDCvDwyqYB6bSpmnmy9N"}

Adding details for example which tree / path and etc has been synchronized will be great for testing purposes.
2. I has been working on testing tree service where I turned on node which contained S3 container and I expected to see something useful in neofs-node logs (something like 'container_id / tree name / is updating / from which node' and etc), but there is no any mention about synchonization of tree service of this S3 container.
3. Since tree service is available only for S3, it would be great to allow neofs-cli tree working with bucket name. It would be great to specify --cid OR --bm (bucket name) - where one of them is required.

@carpawell carpawell removed their assignment Nov 2, 2022
@roman-khimov roman-khimov added S4 Routine I2 Regular impact feature Completely new functionality blocked Can't be done because of something and removed U3 Regular labels Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Can't be done because of something feature Completely new functionality I2 Regular impact neofs-cli NeoFS CLI application issues S4 Routine
Projects
None yet
Development

No branches or pull requests

6 participants