Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connection closed before server preface received #1351

Closed
rkonfj opened this issue May 4, 2022 · 1 comment · Fixed by #1353
Closed

connection closed before server preface received #1351

rkonfj opened this issue May 4, 2022 · 1 comment · Fixed by #1353
Assignees
@cthulhu-rider
Labels
bug Something isn't working
Milestone
v0.28.1

Comments

@rkonfj
Copy link

rkonfj commented May 4, 2022

I got unexpected output when I use neofs-cli

# ./neofs-cli-amd64 accounting balance -r grpcs://st2.storage.fs.neo.org:8082 -w my-wallet-path/wallet.json
Enter password > 
rpc error: write request: rpc error: code = Unavailable desc = connection closed before server preface received

Expected Behavior

Can communicate correctly with storage node

Current Behavior

rpc error: write request: rpc error: code = Unavailable desc = connection closed before server preface received

Your Environment

# ./neofs-cli-amd64 --version
Version: v0.28.0 
Build: 2022-04-29T16:17:25+00:00 
Debug: false
@cthulhu-rider cthulhu-rider added bug Something isn't working and removed triage labels May 4, 2022
@cthulhu-rider cthulhu-rider self-assigned this May 4, 2022
@cthulhu-rider cthulhu-rider added this to the v0.28.1 milestone May 4, 2022
cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue May 4, 2022
[nspcc-dev#1351] cli: Fix connection scheme loss during endpoint parsing
4ede519 
In previous implementation NeoFS CLI app used `network.Address.HostAddr`
as a server URI, which caused scheme loss since host address doesn't
container it.

Add `internal.NetAddr` type with `DecodeString` method to be used by CLI
app. Accept address of this type in `internal.GetSDKClient` function.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue May 4, 2022
[nspcc-dev#1351] cli: Fix connection scheme loss during endpoint parsing
e0ee294 
In previous implementation NeoFS CLI app used `network.Address.HostAddr`
as a server URI, which caused scheme loss since host address doesn't
container it.

Add `internal.NetAddr` type with `DecodeString` method to be used by CLI
app. Accept address of this type in `internal.GetSDKClient` function.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
@cthulhu-rider cthulhu-rider mentioned this issue May 4, 2022
Merged
@cthulhu-rider
Copy link
Contributor

@tasselsd thanks 4 ur report 😸
There was a bug with TLS connections in NeoFS CLI. Expect a patch soon.

cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue May 4, 2022
[nspcc-dev#1351] cli: Fix connection scheme loss during endpoint parsing
6fc4422 
In previous implementation NeoFS CLI app used `network.Address.HostAddr`
as a server URI, which caused scheme loss since host address doesn't
container it.

Add `internal.NetAddr` type with `DecodeString` method to be used by CLI
app. Accept address of this type in `internal.GetSDKClient` function.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue May 4, 2022
[nspcc-dev#1351] cli: Fix connection scheme loss during endpoint parsing
629150e 
In previous implementation NeoFS CLI app used `network.Address.HostAddr`
as a server URI, which caused scheme loss since host address doesn't
contain it.

Rename `HostAddr` to `URIAddr` and make it to return URI address with
`grpcs` scheme if TLS is enabled. Make `TLSEnabled` unexported since it
was used to provide default `tls.Config` only (it is used by default in
SDK).

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit that referenced this issue May 5, 2022
@cthulhu-rider
[#1351] cli: Fix connection scheme loss during endpoint parsing
cd545f0 
In previous implementation NeoFS CLI app used `network.Address.HostAddr`
as a server URI, which caused scheme loss since host address doesn't
contain it.

Rename `HostAddr` to `URIAddr` and make it to return URI address with
`grpcs` scheme if TLS is enabled. Make `TLSEnabled` unexported since it
was used to provide default `tls.Config` only (it is used by default in
SDK).

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
@rkonfj rkonfj mentioned this issue May 5, 2022
Closed
aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue Oct 19, 2022
@aprasolova
[nspcc-dev#1351] cli: Fix connection scheme loss during endpoint parsing
fe9de66 
In previous implementation NeoFS CLI app used `network.Address.HostAddr`
as a server URI, which caused scheme loss since host address doesn't
contain it.

Rename `HostAddr` to `URIAddr` and make it to return URI address with
`grpcs` scheme if TLS is enabled. Make `TLSEnabled` unexported since it
was used to provide default `tls.Config` only (it is used by default in
SDK).

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cthulhu-rider cthulhu-rider

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.28.1
Development

Successfully merging a pull request may close this issue.

cli: Fix connection scheme loss during endpoint parsing cthulhu-rider/neofs-node
2 participants
@cthulhu-rider @rkonfj