Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop network_settings config #2660

Closed
roman-khimov opened this issue Nov 29, 2023 · 2 comments
Closed

Drop network_settings config #2660

roman-khimov opened this issue Nov 29, 2023 · 2 comments
Assignees
Labels
config Configuration format update or breaking change neofs-ir Inner Ring node application issues
Milestone

Comments

@roman-khimov
Copy link
Member

Is your feature request related to a problem? Please describe.

We have it since #2444, but:

  • it's a lot of things to configure
  • autodeploy is deactivated without it
  • this configuration is only relevant for initial deployments, it's not used in any other way
  • network configuration can't be changed by changing it
  • it differs from neofs-adm syntax (
    const configTxtTemplate = `rpc-endpoint: {{ .Endpoint}}
    )

Describe the solution you'd like

Deploy contracts with default parameters (bringing us closer to nspcc-dev/neofs-contract#372), let neofs-adm handle changes. Activate autodeploy/autoupdate with a specific contract_autodeploy flag.

Describe alternatives you've considered

Leaving it in a release doesn't seem to be viable.

@roman-khimov roman-khimov added neofs-ir Inner Ring node application issues config Configuration format update or breaking change labels Nov 29, 2023
@roman-khimov roman-khimov added this to the v0.39.0 milestone Nov 29, 2023
@cthulhu-rider
Copy link
Contributor

contracts_autodeploy sounds insufficient: for example, tokens are transferred and roles are assigned if necessary. I'd call sidechain_autodeploy. Or we may use morph section (where consensus resides for example) and just autodeploy

@roman-khimov
Copy link
Member Author

fschain_autodeploy. No sides, no morphs, please.

cthulhu-rider added a commit that referenced this issue Dec 1, 2023
Network settings configuration did not justify itself because used only
when initializing the FS chain.

Use default network settings during the FS chain auto-deployment (same
ones used by the NeoFS ADM tool). Introduce `fschain_autodeploy` config
flag that replaces mode tuning previously based on `network_settings`
section presence.

Closes #2660.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider added a commit that referenced this issue Dec 1, 2023
Network settings configuration did not justify itself because used only
when initializing the FS chain.

Use default network settings during the FS chain auto-deployment (same
ones used by the NeoFS ADM tool). Introduce `fschain_autodeploy` config
flag that replaces mode tuning previously based on `network_settings`
section presence.

Closes #2660.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider added a commit that referenced this issue Dec 2, 2023
Network settings configuration did not justify itself because used only
when initializing the FS chain.

Use default network settings during the FS chain auto-deployment (same
ones used by the NeoFS ADM tool). Introduce `fschain_autodeploy` config
flag that replaces mode tuning previously based on `network_settings`
section presence.

Closes #2660.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider added a commit that referenced this issue Dec 2, 2023
Network settings configuration did not justify itself because used only
when initializing the FS chain.

Use default network settings during the FS chain auto-deployment (same
ones used by the NeoFS ADM tool). Introduce `fschain_autodeploy` config
flag that replaces mode tuning previously based on `network_settings`
section presence.

Closes #2660.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider added a commit that referenced this issue Dec 2, 2023
Network settings configuration did not justify itself because used only
when initializing the FS chain.

Use default network settings during the FS chain auto-deployment (same
ones used by the NeoFS ADM tool). Introduce `fschain_autodeploy` config
flag that replaces mode tuning previously based on `network_settings`
section presence.

Closes #2660.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config Configuration format update or breaking change neofs-ir Inner Ring node application issues
Projects
None yet
Development

No branches or pull requests

2 participants