-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop network_settings config #2660
Labels
Milestone
Comments
roman-khimov
added
neofs-ir
Inner Ring node application issues
config
Configuration format update or breaking change
labels
Nov 29, 2023
|
|
cthulhu-rider
added a commit
that referenced
this issue
Dec 1, 2023
Network settings configuration did not justify itself because used only when initializing the FS chain. Use default network settings during the FS chain auto-deployment (same ones used by the NeoFS ADM tool). Introduce `fschain_autodeploy` config flag that replaces mode tuning previously based on `network_settings` section presence. Closes #2660. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
added a commit
that referenced
this issue
Dec 1, 2023
Network settings configuration did not justify itself because used only when initializing the FS chain. Use default network settings during the FS chain auto-deployment (same ones used by the NeoFS ADM tool). Introduce `fschain_autodeploy` config flag that replaces mode tuning previously based on `network_settings` section presence. Closes #2660. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
added a commit
that referenced
this issue
Dec 2, 2023
Network settings configuration did not justify itself because used only when initializing the FS chain. Use default network settings during the FS chain auto-deployment (same ones used by the NeoFS ADM tool). Introduce `fschain_autodeploy` config flag that replaces mode tuning previously based on `network_settings` section presence. Closes #2660. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
added a commit
that referenced
this issue
Dec 2, 2023
Network settings configuration did not justify itself because used only when initializing the FS chain. Use default network settings during the FS chain auto-deployment (same ones used by the NeoFS ADM tool). Introduce `fschain_autodeploy` config flag that replaces mode tuning previously based on `network_settings` section presence. Closes #2660. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
added a commit
that referenced
this issue
Dec 2, 2023
Network settings configuration did not justify itself because used only when initializing the FS chain. Use default network settings during the FS chain auto-deployment (same ones used by the NeoFS ADM tool). Introduce `fschain_autodeploy` config flag that replaces mode tuning previously based on `network_settings` section presence. Closes #2660. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
We have it since #2444, but:
neofs-node/cmd/neofs-adm/internal/modules/config/config.go
Line 31 in bbfbd9b
Describe the solution you'd like
Deploy contracts with default parameters (bringing us closer to nspcc-dev/neofs-contract#372), let neofs-adm handle changes. Activate autodeploy/autoupdate with a specific
contract_autodeploy
flag.Describe alternatives you've considered
Leaving it in a release doesn't seem to be viable.
The text was updated successfully, but these errors were encountered: