innerring: Don't stop the same listener twice #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When IR node configured without main chain, both `morphListener` and `mainnetListener` are pointing into single listener component. We should not call `Stop()` twice, because it may trigger channel closing in neo-go or other components and it can throw panic. Signed-off-by: Alex Vanin <alexey@nspcc.ru>
Codecov Report
@@ Coverage Diff @@
## master #1291 +/- ##
==========================================
- Coverage 35.48% 35.48% -0.01%
==========================================
Files 310 310
Lines 19234 19238 +4
==========================================
Hits 6826 6826
- Misses 11869 11873 +4
Partials 539 539
Continue to review full report at Codecov.
|
Signed-off-by: Alex Vanin <alexey@nspcc.ru>
|
do we need that if it gonna be changed in the |
fyrchik
approved these changes
Apr 5, 2022
AnnaShaleva
approved these changes
Apr 5, 2022
I think there's nothing wrong if you'll have this code. |
carpawell
approved these changes
Apr 5, 2022
Merged
aprasolova
pushed a commit
to aprasolova/neofs-node
that referenced
this pull request
Oct 19, 2022
When IR node configured without main chain, both `morphListener` and `mainnetListener` are pointing into single listener component. We should not call `Stop()` twice, because it may trigger channel closing in neo-go or other components and it can throw panic. Signed-off-by: Alex Vanin <alexey@nspcc.ru>
aprasolova
pushed a commit
to aprasolova/neofs-node
that referenced
this pull request
Oct 19, 2022
Signed-off-by: Alex Vanin <alexey@nspcc.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When IR node configured without main chain, both
morphListenerandmainnetListenerare pointing into single listener component. We should not callStop()twice, because it may trigger channel closing in neo-go or other components and it can throw panic.Related to nspcc-dev/neo-go#2420