Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/optional homomorphic hashing #1365

Merged
merged 11 commits into from
May 6, 2022
Merged

Feat/optional homomorphic hashing #1365

merged 11 commits into from
May 6, 2022

Conversation

carpawell
Copy link
Member

@carpawell carpawell commented May 5, 2022 •
edited
Loading

Related to #1300.

@carpawell carpawell added the enhancement Improving existing functionality label May 5, 2022
@carpawell carpawell self-assigned this May 5, 2022
@carpawell carpawell marked this pull request as ready for review May 5, 2022 16:31
@carpawell
[#1365] *: Adopt SDK and API changes
5835269 
Marshalling does not return errors anymore.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@carpawell
[#1365] cli: Add SyncContainerSettings func to internal client
0b5cac6 
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@carpawell
[#1365] cli: Sync container with network config
7d7581d 
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@carpawell
[#1365] cli: Calculate homomorphic hash flexibly
854c850 
Do not use homomorphic hash in storage group for containers that have
`homomorphic_hashing_disabled` set to `true`.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@carpawell
[#1365] morph: Add HomomorphicHashDisabled config getter
96934ca 
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@carpawell
[#1365] ir: Check homomorphic hash setting on ContainerPut
7674d32 
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@carpawell
[#1365] ir: Check homomorphic hash flexibly in audit
e444eca 
Do not perform that check if it was turned off for the container being
checked.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@carpawell
[#1365] node: Calculate object homomorphic hash flexibly
f37922c 
Do not calculate and do not write homomorphic hash for containers that were
configured to store objects without hash.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@carpawell
[#1365] cli: Fix putting container
fd1a8c3 
Add container to the `PutContainerPrm` only after sync to allow change
container's parameters.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@carpawell
Copy link
Member Author

@fyrchik, please, check d892d04 changes in neofs-adm

@carpawell
Copy link
Member Author

carpawell commented May 6, 2022 •
edited
Loading

@cthulhu-rider, @fyrchik added 3826a44 that makes it possible for "new" nodes to work in "old" chains that do not have any info about the new holomorphic key in the config.

Added a default value only for HomomorphicHashDisabled: it seems that only that method is optional in cfg for now.

fyrchik
fyrchik reviewed May 6, 2022
View reviewed changes
cmd/neofs-adm/internal/modules/morph/initialize_deploy.go Outdated
Comment on lines 582 to 585
{Type: smartcontract.IntegerType, Value: viper.GetInt64(withdrawFeeInitFlag)},
{Type: smartcontract.BoolType, Value: viper.GetBool(homomorphicHashDisabledInitFlag)},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we should first have key (string), next its value. I see only value here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, forgot that, thanks, fixed

@carpawell
[#1365] adm: Add homomorphic hash disabling option
7398200 
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@carpawell
[#1365] morph: Do not return errors if config key is missing
52d8c4b 
Return default values instead of casting errors in `HomomorphicHashDisabled`
method.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@cthulhu-rider cthulhu-rider merged commit 98525c0 into nspcc-dev:feat/optional-homomorphic-hashing May 6, 2022
cthulhu-rider pushed a commit that referenced this pull request May 6, 2022
@carpawell @cthulhu-rider
[#1365] *: Adopt SDK and API changes
be52f43 
Marshalling does not return errors anymore.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
cthulhu-rider pushed a commit that referenced this pull request May 6, 2022
@carpawell @cthulhu-rider
[#1365] cli: Add SyncContainerSettings func to internal client
a41be61 
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
cthulhu-rider pushed a commit that referenced this pull request May 6, 2022
@carpawell @cthulhu-rider
[#1365] cli: Sync container with network config
9315838 
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
cthulhu-rider pushed a commit that referenced this pull request May 6, 2022
@carpawell @cthulhu-rider
[#1365] cli: Calculate homomorphic hash flexibly
98cfc53 
Do not use homomorphic hash in storage group for containers that have
`homomorphic_hashing_disabled` set to `true`.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
cthulhu-rider pushed a commit that referenced this pull request May 6, 2022
@carpawell @cthulhu-rider
[#1365] morph: Add HomomorphicHashDisabled config getter
8607feb 
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
cthulhu-rider pushed a commit that referenced this pull request May 6, 2022
@carpawell @cthulhu-rider
[#1365] ir: Check homomorphic hash setting on ContainerPut
a137c87 
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
cthulhu-rider pushed a commit that referenced this pull request May 6, 2022
@carpawell @cthulhu-rider
[#1365] ir: Check homomorphic hash flexibly in audit
65effd0 
Do not perform that check if it was turned off for the container being
checked.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
cthulhu-rider pushed a commit that referenced this pull request May 6, 2022
@carpawell @cthulhu-rider
[#1365] node: Calculate object homomorphic hash flexibly
61d5cec 
Do not calculate and do not write homomorphic hash for containers that were
configured to store objects without hash.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
cthulhu-rider pushed a commit that referenced this pull request May 6, 2022
@carpawell @cthulhu-rider
[#1365] cli: Fix putting container
d57c621 
Add container to the `PutContainerPrm` only after sync to allow change
container's parameters.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
cthulhu-rider pushed a commit that referenced this pull request May 6, 2022
@carpawell @cthulhu-rider
[#1365] adm: Add homomorphic hash disabling option
5c20c68 
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@carpawell carpawell deleted the feat/optional-homomorphic-hashing branch May 6, 2022 20:32
This was referenced May 12, 2022
Closed
Closed
Closed
Closed
aprasolova pushed a commit to aprasolova/neofs-node that referenced this pull request Oct 19, 2022
@carpawell @aprasolova
[nspcc-dev#1365] cli: Add SyncContainerSettings func to internal cl…
e24a44d 
…ient

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this pull request Oct 19, 2022
@carpawell @aprasolova
[nspcc-dev#1365] cli: Sync container with network config
4ea95f2 
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this pull request Oct 19, 2022
@carpawell @aprasolova
[nspcc-dev#1365] cli: Calculate homomorphic hash flexibly
65301c3 
Do not use homomorphic hash in storage group for containers that have
`homomorphic_hashing_disabled` set to `true`.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this pull request Oct 19, 2022
@carpawell @aprasolova
[nspcc-dev#1365] morph: Add HomomorphicHashDisabled config getter
9d45164 
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this pull request Oct 19, 2022
@carpawell @aprasolova
[nspcc-dev#1365] ir: Check homomorphic hash setting on ContainerPut
a865199 
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this pull request Oct 19, 2022
@carpawell @aprasolova
[nspcc-dev#1365] ir: Check homomorphic hash flexibly in audit
1315a0a 
Do not perform that check if it was turned off for the container being
checked.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this pull request Oct 19, 2022
@carpawell @aprasolova
[nspcc-dev#1365] node: Calculate object homomorphic hash flexibly
89e0bcd 
Do not calculate and do not write homomorphic hash for containers that were
configured to store objects without hash.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this pull request Oct 19, 2022
@carpawell @aprasolova
[nspcc-dev#1365] adm: Add homomorphic hash disabling option
527e08b 
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this pull request Oct 19, 2022
@carpawell @aprasolova
[nspcc-dev#1365] morph: Do not return errors if config key is missing
37e0593 
Return default values instead of casting errors in `HomomorphicHashDisabled`
method.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@roman-khimov roman-khimov mentioned this pull request Apr 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cthulhu-rider cthulhu-rider cthulhu-rider approved these changes

@fyrchik fyrchik fyrchik approved these changes

Assignees

@carpawell carpawell

Labels
enhancement Improving existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carpawell @fyrchik @cthulhu-rider