Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Unlock locked object on its lock removal #1440

Closed
wants to merge 5 commits into from
Closed

Fix: Unlock locked object on its lock removal #1440

wants to merge 5 commits into from

Conversation

carpawell
Copy link
Member

@carpawell carpawell commented May 26, 2022

See #1227 (comment).

Also, more tests in SE will be added if PR is valid after the discussion.

@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #1440 (2b24044) into master (cc6209e) will increase coverage by 0.01%.
The diff coverage is 15.49%.

❗ Current head 2b24044 differs from pull request most recent head f97bf54. Consider uploading reports for the commit f97bf54 to get more accurate results

@@            Coverage Diff             @@
##           master    #1440      +/-   ##
==========================================
+ Coverage   36.52%   36.53%   +0.01%     
==========================================
  Files         305      305              
  Lines       18001    18065      +64     
==========================================
+ Hits         6574     6600      +26     
- Misses      10861    10896      +35     
- Partials      566      569       +3     
Impacted Files Coverage Δ
pkg/core/object/fmt.go 58.55% <0.00%> (-2.00%) ⬇️
pkg/local_object_storage/engine/delete.go 0.00% <0.00%> (ø)
pkg/local_object_storage/engine/inhume.go 64.51% <0.00%> (+6.18%) ⬆️
pkg/local_object_storage/shard/gc.go 22.38% <0.00%> (-1.18%) ⬇️
pkg/local_object_storage/shard/shard.go 60.71% <0.00%> (-2.25%) ⬇️
pkg/local_object_storage/shard/inhume.go 37.83% <10.00%> (-12.17%) ⬇️
pkg/local_object_storage/metabase/inhume.go 72.63% <30.43%> (-11.58%) ⬇️
pkg/local_object_storage/engine/shards.go 79.72% <100.00%> (+0.27%) ⬆️
pkg/local_object_storage/metabase/util.go 94.82% <100.00%> (+0.18%) ⬆️
pkg/local_object_storage/metabase/lock.go 63.29% <0.00%> (+8.86%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc6209e...f97bf54. Read the comment docs.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@carpawell
Copy link
Member Author

carpawell commented May 31, 2022

Would be added to master via the feature branch: #1461.

@carpawell carpawell closed this May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant