metabase: store version #1521
Merged
metabase: store version #1521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1521 +/- ##
==========================================
+ Coverage 35.56% 35.69% +0.12%
==========================================
Files 307 308 +1
Lines 18230 18266 +36
==========================================
+ Hits 6484 6520 +36
+ Misses 11201 11198 -3
- Partials 545 548 +3
Continue to review full report at Codecov.
|
carpawell
reviewed
Jun 20, 2022
|
|
||
| - Container ID is encoded as base58 string | ||
| - Object ID is encoded as base58 string | ||
| - Address is encoded as object ID + "/" + container ID |
There was a problem hiding this comment.
are you sure? not as "container ID + "/" + obejct ID"?
The main problem is to distinguish the case of initial initialization and update from version 0. We can't do this at `Open`, because of `resync_metabase` flag. Thus, the following approach was taken: 1. During `Open` check whether the metabase was initialized. 2. Check for the version in `Init` or write the new one if the metabase is new. 3. Update version in `Reset`. Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
carpawell
approved these changes
Jun 21, 2022
cthulhu-rider
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1483.
Signed-off-by: Evgenii Stratonikov evgeniy@nspcc.ru