services/tree: do not restrict depth in GetSubTree
#1753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1753 +/- ##
==========================================
+ Coverage 33.08% 33.24% +0.16%
==========================================
Files 351 351
Lines 23481 23492 +11
==========================================
+ Hits 7769 7811 +42
+ Misses 15061 15028 -33
- Partials 651 653 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
KirillovDenis
previously approved these changes
Sep 5, 2022
|
Shouldn't we get rid of this? |
cthulhu-rider
previously approved these changes
Sep 6, 2022
alexvanin
previously approved these changes
Sep 6, 2022
Previously, the depth was restricted because with BFS the amount of nodes we have in memory blows up exponentially. With DFS is is linear, so we can process trees of arbitrary depth. Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
It was used only in `GetOpLog` and ignored on the server side. Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
…response Currently, you need to use `GetSubTree` to get parent, which seems an overkill. Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
cthulhu-rider
approved these changes
Sep 7, 2022
Merged
aprasolova
pushed a commit
to aprasolova/neofs-node
that referenced
this pull request
Oct 19, 2022
Previously, the depth was restricted because with BFS the amount of nodes we have in memory blows up exponentially. With DFS is is linear, so we can process trees of arbitrary depth. Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
aprasolova
pushed a commit
to aprasolova/neofs-node
that referenced
this pull request
Oct 19, 2022
It was used only in `GetOpLog` and ignored on the server side. Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
aprasolova
pushed a commit
to aprasolova/neofs-node
that referenced
this pull request
Oct 19, 2022
…response Currently, you need to use `GetSubTree` to get parent, which seems an overkill. Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the depth was restricted because with BFS the amount of
nodes we have in memory blows up exponentially. With DFS is is linear,
so we can process trees of arbitrary depth.
Refs nspcc-dev/neofs-s3-gw#624
Signed-off-by: Evgenii Stratonikov evgeniy@morphbits.ru