Validate config before usage #1805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carpawell
reviewed
Sep 20, 2022
| @@ -26,7 +28,7 @@ func (x *Config) Storages() []*storage.Config { | |||
| switch typ { | |||
| case "": | |||
| return ss | |||
| case "fstree", "blobovnicza": | |||
| case fstree.Type, blobovniczatree.Type: | |||
There was a problem hiding this comment.
maybe "TypeName"? i read it as a type name, not a var name, and was confused for a second about how that even was compiled and whether it is a type switch
There was a problem hiding this comment.
The intention was to make it similar to a Type method for a storage component.
Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
Codecov Report
@@ Coverage Diff @@
## master #1805 +/- ##
==========================================
- Coverage 33.45% 30.80% -2.66%
==========================================
Files 352 372 +20
Lines 23969 26105 +2136
==========================================
+ Hits 8020 8041 +21
- Misses 15283 17388 +2105
- Partials 666 676 +10
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
carpawell
approved these changes
Sep 26, 2022
acid-ant
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need this for #1770 .
Related #1764.
The list of checks will be extended. Currently only storage section is supported, as the most important one.