Fix/Do not boot up if metabase is outdated #1809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carpawell
added
bug
Codecov Report
@@ Coverage Diff @@
## master #1809 +/- ##
==========================================
- Coverage 31.06% 31.06% -0.01%
==========================================
Files 374 374
Lines 26377 26379 +2
==========================================
Hits 8195 8195
- Misses 17492 17494 +2
Partials 690 690
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
acid-ant
previously approved these changes
Sep 22, 2022
fyrchik
reviewed
Sep 22, 2022
CHANGELOG.md
Outdated
| @@ -9,6 +9,8 @@ Changelog for NeoFS Node | |||
|
|
|||
| ### Fixed | |||
|
|
|||
| - Outdated metabase start up (#1809) | |||
There was a problem hiding this comment.
"fail startup if metabase has old version"?
fyrchik
reviewed
Sep 22, 2022
Comment on lines
15
to
23
| // ErrOutdatedVersion is returned on initializing | ||
| // an existing metabase that is not compatible with | ||
| // the current code version. | ||
| type ErrOutdatedVersion struct { | ||
| stored uint64 | ||
| } | ||
|
|
||
| func (e ErrOutdatedVersion) Error() string { | ||
| return fmt.Sprintf("invalid version: expected=%d, stored=%d", version, e.stored) |
There was a problem hiding this comment.
I don't like complex error types, what about var ErrOutdatedVersion = errors.New("invalid version") + return fmt.Errorf("%w: expected...", ErrOutdatedVersion, ...)?
There was a problem hiding this comment.
Here I agree with @fyrchik at least since we don't decode the error structure. We could use errors.Is.
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
fyrchik
approved these changes
Oct 4, 2022
aprasolova
pushed a commit
to aprasolova/neofs-node
that referenced
this pull request
Oct 19, 2022
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.