Refactor/Config in SN #1830
Merged
Refactor/Config in SN #1830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1830 +/- ##
==========================================
- Coverage 31.23% 31.22% -0.01%
==========================================
Files 375 375
Lines 26438 26440 +2
==========================================
Hits 8257 8257
- Misses 17494 17496 +2
Partials 687 687
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cthulhu-rider
previously approved these changes
Oct 4, 2022
fyrchik
previously approved these changes
Oct 5, 2022
Split all the fields in `cfg` structure on: 1. `applicationConfiguration`; 2. `internals`; // shared entities for an application work, such as `context.Context` 3. `shared`; // holder for the shared entities b/w; 4. `cfgXXX`; // configuration for internal services. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
|
@cthulhu-rider, @fyrchik, resolved conflicts. |
carpawell
added
U2
cthulhu-rider
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by:
Related to #1770.