Support --timeout in neofs-cli
#1837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1837 +/- ##
=======================================
Coverage 31.22% 31.23%
=======================================
Files 375 374 -1
Lines 26440 26438 -2
=======================================
Hits 8257 8257
+ Misses 17496 17494 -2
Partials 687 687
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cthulhu-rider
previously approved these changes
Oct 5, 2022
Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
Allow to specify it everywhere `--rpc-endpoint` flag is present. Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
Avoid encoding object ID to string. Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
|
Rebased on master. |
acid-ant
reviewed
Oct 6, 2022
|
|
||
| mtx.Lock() | ||
| exec.writeIDList(ids) | ||
| mtx.Unlock() |
There was a problem hiding this comment.
Should we defer this unlock?
There was a problem hiding this comment.
We could but it is simple enough like this, writeIDList is not expected to panic.
acid-ant
approved these changes
Oct 6, 2022
cthulhu-rider
approved these changes
Oct 7, 2022
aprasolova
pushed a commit
to aprasolova/neofs-node
that referenced
this pull request
Oct 19, 2022
Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
aprasolova
pushed a commit
to aprasolova/neofs-node
that referenced
this pull request
Oct 19, 2022
Avoid encoding object ID to string. Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1826.
Also, improve object.Search service.