Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to store/restore/delete binary objects #1924

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

acid-ant
Copy link
Contributor

@acid-ant acid-ant commented Oct 18, 2022

Closes #1338

With flag --binary user can point to the file with serialized object structure - id + signature + header + payload
Added for development purposes.

Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com

@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #1924 (730c772) into master (1f82c58) will increase coverage by 0.03%.
The diff coverage is 50.00%.

❗ Current head 730c772 differs from pull request most recent head b39c69d. Consider uploading reports for the commit b39c69d to get more accurate results

@@            Coverage Diff             @@
##           master    #1924      +/-   ##
==========================================
+ Coverage   30.42%   30.45%   +0.03%     
==========================================
  Files         380      380              
  Lines       27777    27718      -59     
==========================================
- Hits         8451     8442       -9     
+ Misses      18630    18583      -47     
+ Partials      696      693       -3     
Impacted Files Coverage Δ
cmd/neofs-cli/modules/acl/extended/create.go 52.51% <50.00%> (ø)
cmd/neofs-node/config.go 0.00% <0.00%> (ø)
cmd/neofs-adm/internal/modules/morph/container.go 0.00% <0.00%> (ø)
cmd/neofs-adm/internal/modules/morph/root.go 50.34% <0.00%> (+0.01%) ⬆️
pkg/local_object_storage/blobstor/fstree/fstree.go 68.02% <0.00%> (+0.99%) ⬆️
pkg/local_object_storage/writecache/storage.go 28.16% <0.00%> (+1.02%) ⬆️
pkg/local_object_storage/writecache/options.go 57.14% <0.00%> (+4.51%) ⬆️
pkg/local_object_storage/blobstor/fstree/option.go 75.00% <0.00%> (+15.00%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cthulhu-rider
Copy link
Contributor

Do we declare merging behavior of the command? I mean if we provide filepath to serialized object, and specifiy, for example, attributes, they are set in the resulting object.

If so, IMO this complicates the command. I would prefer to have indiviual commands for object formation and storing.

@fyrchik

cmd/neofs-cli/modules/object/put.go Outdated Show resolved Hide resolved
cmd/neofs-cli/modules/object/put.go Outdated Show resolved Hide resolved
cmd/neofs-cli/modules/object/util.go Outdated Show resolved Hide resolved
@fyrchik
Copy link
Contributor

fyrchik commented Nov 1, 2022

Could you add neofs-cli: prefix to a commit message?

…y objects

Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
@fyrchik fyrchik merged commit bb52857 into nspcc-dev:master Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support storing binary objects
4 participants