Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1907] shard: Return from Close after GC has stopped #1964

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Oct 25, 2022

Close #1907.

I hasn't been able to reproduce, but this should fix it.
Signed-off-by: Evgenii Stratonikov evgeniy@morphbits.ru

Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #1964 (1ccf643) into master (8796807) will decrease coverage by 0.02%.
The diff coverage is 17.24%.

@@            Coverage Diff             @@
##           master    #1964      +/-   ##
==========================================
- Coverage   30.58%   30.56%   -0.03%     
==========================================
  Files         378      379       +1     
  Lines       27589    27634      +45     
==========================================
+ Hits         8437     8445       +8     
- Misses      18455    18492      +37     
  Partials      697      697              
Impacted Files Coverage Δ
cmd/neofs-adm/internal/modules/morph/config.go 0.00% <0.00%> (ø)
cmd/neofs-adm/internal/modules/morph/container.go 0.00% <0.00%> (ø)
cmd/neofs-adm/internal/modules/morph/epoch.go 0.00% <0.00%> (ø)
cmd/neofs-adm/internal/modules/morph/initialize.go 0.00% <0.00%> (ø)
...-adm/internal/modules/morph/initialize_register.go 0.00% <0.00%> (ø)
...-adm/internal/modules/morph/initialize_transfer.go 0.00% <0.00%> (ø)
...d/neofs-adm/internal/modules/morph/local_client.go 0.00% <0.00%> (ø)
...md/neofs-adm/internal/modules/morph/remove_node.go 0.00% <0.00%> (ø)
cmd/neofs-node/session.go 0.00% <0.00%> (ø)
pkg/local_object_storage/blobstor/delete.go 0.00% <0.00%> (ø)
... and 6 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fyrchik fyrchik merged commit 713fdab into nspcc-dev:master Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup tests properly
3 participants