engine: always select proper shard for a tree #1996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1996 +/- ##
==========================================
+ Coverage 30.50% 30.51% +0.01%
==========================================
Files 380 380
Lines 27808 27833 +25
==========================================
+ Hits 8482 8494 +12
- Misses 18625 18638 +13
Partials 701 701
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
carpawell
approved these changes
Nov 2, 2022
|
|
||
| // TreeExists implements the pilorama.Forest interface. | ||
| func (f *memoryForest) TreeExists(cid cidSDK.ID, treeID string) (bool, error) { | ||
| fullID := cid.String() + "/" + treeID |
There was a problem hiding this comment.
Suggested change
| fullID := cid.String() + "/" + treeID | |
| fullID := cid.EncodeToString() + "/" + treeID |
Currently there is a possibility for modifying operations to fail because of I/O errors and a new tree to be created on another shard. This commit adds existence check for modifying operations. Read operations remain as they are, not to slow things. `TreeDrop` is an exception, because this is a tree removal and trying multiple shards is not an unwanted behaviour. Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is a possibility for modifying operations to fail because of I/O errors and a new tree to be created on another shard. This commit adds existence check for modifying operations. Read operations remain as they are, not to slow things.
TreeDropis an exception, because this is a tree removal and trying multiple shards is not an unwanted behaviour.Signed-off-by: Evgenii Stratonikov evgeniy@morphbits.ru