Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

object/put: use sync.Pool for temporary payloads #2139

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Dec 7, 2022

No description provided.

@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #2139 (bf9f8b8) into master (dcdf27b) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head bf9f8b8 differs from pull request most recent head b7a6270. Consider uploading reports for the commit b7a6270 to get more accurate results

@@            Coverage Diff             @@
##           master    #2139      +/-   ##
==========================================
+ Coverage   30.76%   30.78%   +0.01%     
==========================================
  Files         382      382              
  Lines       28095    28056      -39     
==========================================
- Hits         8644     8637       -7     
+ Misses      18717    18687      -30     
+ Partials      734      732       -2     
Impacted Files Coverage Δ
cmd/neofs-node/tree.go 0.00% <0.00%> (ø)
pkg/services/tree/sync.go 0.00% <0.00%> (ø)
pkg/services/tree/options.go 0.00% <0.00%> (ø)
pkg/services/object/get/assemble.go 89.23% <0.00%> (ø)
cmd/neofs-node/config/tree/config.go 100.00% <0.00%> (ø)
pkg/local_object_storage/shard/mode.go 100.00% <0.00%> (ø)
pkg/local_object_storage/shard/shard.go 69.29% <0.00%> (ø)
pkg/local_object_storage/engine/metrics.go 0.00% <0.00%> (ø)
pkg/local_object_storage/pilorama/inmemory.go 100.00% <0.00%> (ø)
pkg/services/tree/service.go 8.37% <0.00%> (+0.02%) ⬆️
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@carpawell carpawell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain the idea a little?

Copy link
Member

@carpawell carpawell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My fault: i did not notice getPayload call and thought that Pool was used write-only.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
@fyrchik fyrchik merged commit 3a3b47b into nspcc-dev:master Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants