Fix/Storage Group expiration #2167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carpawell
requested review from
alexvanin,
fyrchik and
cthulhu-rider
as code owners
Codecov Report
@@ Coverage Diff @@
## master #2167 +/- ##
==========================================
+ Coverage 30.79% 30.81% +0.02%
==========================================
Files 382 382
Lines 28137 28161 +24
==========================================
+ Hits 8664 8679 +15
- Misses 18739 18751 +12
+ Partials 734 731 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
fyrchik
reviewed
Dec 20, 2022
Signed-off-by: Pavel Karpy <p.karpy@yadro.com>
acid-ant
approved these changes
Dec 20, 2022
fyrchik
reviewed
Dec 20, 2022
fyrchik
approved these changes
Dec 20, 2022
added 2 commits
December 20, 2022 17:27
Both `meta` and `write-cache` are expected to have a fast underlying disk, so it does not seem like an optimisation. Moreover, `write-cache`'s `Head` is a `Get` with payload cutting, it _must_ use more memory for no reason (`meta` was created for such requests). Also, `write-cache` does not allow performing any "meta" relations checks (such as locking, tombstoning). Signed-off-by: Pavel Karpy <p.karpy@yadro.com>
`meta` should prevent returning removed objects (`GCMark` and `TS` relations are `meta` abstractions). Signed-off-by: Pavel Karpy <p.karpy@yadro.com>
fyrchik
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2016.