Close pilorama in degraded mode #2197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acid-ant
previously approved these changes
Jan 11, 2023
|
Tests+changelog. |
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
Codecov Report
@@ Coverage Diff @@
## support/v0.35 #2197 +/- ##
=================================================
+ Coverage 30.75% 30.77% +0.01%
=================================================
Files 382 382
Lines 28237 28283 +46
=================================================
+ Hits 8685 8703 +18
- Misses 18820 18834 +14
- Partials 732 746 +14
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
carpawell
approved these changes
Jan 12, 2023
| @@ -71,12 +78,9 @@ func (t *boltForest) SetMode(m mode.Mode) error { | |||
| if t.mode == m { | |||
| return nil | |||
| } | |||
| if t.mode.ReadOnly() == m.ReadOnly() { | |||
| return nil | |||
| } | |||
|
|
|||
| err := t.Close() | |||
There was a problem hiding this comment.
not related to that PR but why is it the t receiver for boltForest? i thought that i was looking at a test code for a second
There was a problem hiding this comment.
t for forest of Trees (initially it was all about trees, so t stuck)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Evgenii Stratonikov e.stratonikov@yadro.com