Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Do not return expired objects #2213

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Fix/Do not return expired objects #2213

merged 1 commit into from
Jan 31, 2023

Conversation

carpawell
Copy link
Member

"Object is expired" means that object is presented in meta but it is not ObjectNotFound error. Previous implementation made shard search for an object without meta which was an error.

Signed-off-by: Pavel Karpy p.karpy@yadro.com

@carpawell carpawell added bug Something isn't working neofs-storage Storage node application issues U0 Needs to be resolved immediately yaczrokh labels Jan 25, 2023
@carpawell carpawell self-assigned this Jan 25, 2023
@carpawell carpawell marked this pull request as ready for review January 25, 2023 15:50
@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Merging #2213 (ed3361e) into support/v0.35 (07efe97) will increase coverage by 0.00%.
The diff coverage is 82.31%.

❗ Current head ed3361e differs from pull request most recent head bebfcb2. Consider uploading reports for the commit bebfcb2 to get more accurate results

@@              Coverage Diff               @@
##           support/v0.35    #2213   +/-   ##
==============================================
  Coverage          30.88%   30.89%           
==============================================
  Files                383      383           
  Lines              28352    28365   +13     
==============================================
+ Hits                8757     8762    +5     
- Misses             18849    18855    +6     
- Partials             746      748    +2     
Impacted Files Coverage Δ
pkg/local_object_storage/pilorama/types.go 100.00% <ø> (ø)
pkg/morph/client/notifications.go 0.00% <0.00%> (ø)
pkg/services/object/acl/v2/service.go 0.00% <0.00%> (ø)
pkg/services/tree/replicator.go 0.00% <0.00%> (ø)
pkg/services/tree/service.go 8.35% <0.00%> (+0.10%) ⬆️
pkg/local_object_storage/engine/get.go 80.45% <25.00%> (-1.69%) ⬇️
pkg/local_object_storage/shard/get.go 76.19% <69.23%> (-10.48%) ⬇️
pkg/local_object_storage/blobstor/fstree/fstree.go 66.48% <75.00%> (-0.18%) ⬇️
pkg/local_object_storage/pilorama/boltdb.go 79.85% <89.58%> (+0.36%) ⬆️
...kg/local_object_storage/blobovnicza/blobovnicza.go 82.85% <100.00%> (ø)
... and 9 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

fyrchik
fyrchik previously approved these changes Jan 31, 2023
"Object is expired" means that object is presented in `meta` but it is not
`ObjectNotFound` error. Previous implementation made `shard` search for an
object without `meta` which was an error.

Signed-off-by: Pavel Karpy <p.karpy@yadro.com>
@fyrchik fyrchik merged commit c0d91d8 into nspcc-dev:support/v0.35 Jan 31, 2023
@carpawell carpawell deleted the fix/do-not-return-expired-objects branch January 31, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working neofs-storage Storage node application issues U0 Needs to be resolved immediately
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants